feat: support 7TV overrides and emoji-emotes#283
Draft
Nerixyz wants to merge 2 commits into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (state.hasBits && this->tryAppendCheermote(state, word)) | ||
| { | ||
| // This string was parsed as a cheermote | ||
| cursor += word.size() + 1; |
There was a problem hiding this comment.
warning: narrowing conversion from 'qsizetype' (aka 'long long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
rmote
^| if (this->tryAppendEmote(state.twitchChannel, state.userID, {word})) | ||
| { | ||
| // Successfully appended an emote | ||
| cursor += word.size() + 1; |
There was a problem hiding this comment.
warning: narrowing conversion from 'qsizetype' (aka 'long long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
emote
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the parsing a bit (for the better, imo), since we parse emojis after emotes now. The next step would be to correctly set the trailing space if an emoji is found in a word (that's for c2 or if users complain).