-
Notifications
You must be signed in to change notification settings - Fork 10
No instruct dp #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
No instruct dp #20
Changes from all commits
8915779
b460db5
63fb433
7685ef3
e420019
59367bd
5a7257a
668e16c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,12 @@ | ||
[ | ||
{"label": "CC-Qwen-2.5-7B-Instruct (ctx)", "method": "directprompt", "llm": "qwen2.5-7B-Instruct", "use_context": true, "temperature": 1.0, | ||
"batch_size_on_retry":10, "batch_size":10, "n_retries": 10} | ||
] | ||
{ | ||
"label": "CC-Qwen-2.5-7B-Instruct (ctx)", | ||
"method": "directprompt", | ||
"llm": "qwen2.5-7B-Instruct", | ||
"use_context": true, | ||
"temperature": 1.0, | ||
"batch_size_on_retry": 10, | ||
"batch_size": 10, | ||
"n_retries": 10 | ||
} | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
[ | ||
{"label": "Statsmodels", "method": "statsmodels"} | ||
] | ||
{ | ||
"label": "Statsmodels", | ||
"method": "statsmodels" | ||
} | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,5 +19,6 @@ termcolor | |
tenacity | ||
h5py | ||
transformers>4.4.1 | ||
tokenizers | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this necessary for mamba or something? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I can remove it though since I didn't add the mamba models There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that'd be great cause it might break the already-fragile requirements otherwise :D Unless you tested that it didn't :) |
||
sentencepiece | ||
lm-format-enforcer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to replace the original function? This might break reproducibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original function allowed for returns such as \n \n \n \n \n \n \n ... so I fixed it to this when working with Hymba. I think it would only break reproducibility if this code is somehow encoded into controlling the RNG for the llm or for the tasks, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcotet what are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, all results of our paper were with the previous code so I guess it was fine - we didn't get any errors.
If you think it's better maybe good to reproduce a model's results on CiK to confirm it doesn't break reproducibility. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does mamba need this change?