Override NormalizeSurname for Polish Culture #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burtek
changed the title
burtek
commented
May 14, 2024
Comment on lines
+44
to
+45
| if (sn.EndsWith("nа")) { | ||
| sn = sn.Substring(0, sn.Length - 1) + "y"; |
There was a problem hiding this comment.
That's the most common case (other than -ska/-cka/-dzka). There are other cases that are not cover by this, but it depends on the whole word rather than ending and would be hard or impossible to account for all possibilities - though if needed, I can imagine those being in future PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552
Based on https://github.com/Serg-Norseman/GEDKeeper/blob/master/projects/GKCore/GKCore/Cultures/RussianCulture.cs