-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedora build on GitHub Actions #484
Conversation
- name: .NET SDK check | ||
run: dotnet sdk check | ||
# error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'freebsd-x64' | ||
# https://learn.microsoft.com/en-us/dotnet/devops/dotnet-build-github-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, RID freebsd-x64
should have been removed a long time ago. I seem to have taken it from the freebsd dotnet build articles, but they have long-standing problems with MS (it seems) and the RID is not valid.
find ./locales -type f -exec chmod -x '{}' \; | ||
find ./plugins -type f -exec chmod -x '{}' \; | ||
find ./scripts -type f -exec chmod -x '{}' \; | ||
find ./samples -type f -exec chmod -x '{}' \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it's not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, %setup macro does:
chmod -Rf a+rX,u+w,g-w,o-w .
Does we need some files executable? (except main)
If we want to make sure all files no executable we can use this:
chmod -cRf a-x,a+rX,u+w,g-w,o-w .
# after these make main file executable
|
||
jobs: | ||
build-fedora: | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this actually needs to be built in
Fedora, not on Ubuntu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not need any specific packages for separate build this project in Fedora.
Terminal=false | ||
Type=Application | ||
Categories=Office | ||
StartupNotify=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of copying an already existing file here? Why maintain two files with identical content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is a draft.
What is done
dotnet
compilling (or can use RID for this)APP_VER
variable in rpm build (needs only in spec-file)Current problems
deploy/rpm/gk_files.txt
was outdated. Maybe I missed some dirs/files.dotnet restore
separated in task, looking for FreeBSD RID. (I'm not .NET developer, and I don't know why manual recommend this).