Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora build on GitHub Actions #484

Merged
merged 7 commits into from
Aug 4, 2023
Merged

Conversation

guard43ru
Copy link
Contributor

@guard43ru guard43ru commented Aug 2, 2023

This is a draft.

What is done

  • Make rpm on default runner (ubuntu). I think no need specific linux distro for dotnet compilling (or can use RID for this)
  • Removed APP_VER variable in rpm build (needs only in spec-file)
  • Removed custom chown in spec-file (rpmbuild reset all permissions)

Current problems

  • Plugins was compiled for multi-arch (mips64, arm) ans OS (win, osx), this results in an error in rpmbuild.
+ /usr/lib/rpm/brp-strip /usr/bin/strip
/usr/bin/strip: Unable to recognise the format of the input file `/home/runner/rpmbuild/BUILDROOT/gedkeeper-3.2.1-1.x86_64/usr/lib64/gedkeeper/plugins/runtimes/linux-mips64/native/libe_sqlite3.so'
/usr/bin/strip: Unable to recognise the format of the input file `/home/runner/rpmbuild/BUILDROOT/gedkeeper-3.2.1-1.x86_64/usr/lib64/gedkeeper/plugins/runtimes/linux-armel/native/libe_sqlite3.so'
/usr/bin/strip: Unable to recognise the format of the input file `/home/runner/rpmbuild/BUILDROOT/gedkeeper-3.2.1-1.x86_64/usr/lib64/gedkeeper/plugins/runtimes/linux-arm/native/libe_sqlite3.so'
/usr/bin/strip: Unable to recognise the format of the input file `/home/runner/rpmbuild/BUILDROOT/gedkeeper-3.2.1-1.x86_64/usr/lib64/gedkeeper/plugins/runtimes/linux-arm64/native/libe_sqlite3.so'
  • I think deploy/rpm/gk_files.txt was outdated. Maybe I missed some dirs/files.
  • When dotnet restore separated in task, looking for FreeBSD RID. (I'm not .NET developer, and I don't know why manual recommend this).
error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'freebsd-x64'

- name: .NET SDK check
run: dotnet sdk check
# error NETSDK1084: There is no application host available for the specified RuntimeIdentifier 'freebsd-x64'
# https://learn.microsoft.com/en-us/dotnet/devops/dotnet-build-github-action
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, RID freebsd-x64 should have been removed a long time ago. I seem to have taken it from the freebsd dotnet build articles, but they have long-standing problems with MS (it seems) and the RID is not valid.

find ./locales -type f -exec chmod -x '{}' \;
find ./plugins -type f -exec chmod -x '{}' \;
find ./scripts -type f -exec chmod -x '{}' \;
find ./samples -type f -exec chmod -x '{}' \;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's not needed?

Copy link
Contributor Author

@guard43ru guard43ru Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, %setup macro does:

chmod -Rf a+rX,u+w,g-w,o-w .

Does we need some files executable? (except main)
If we want to make sure all files no executable we can use this:

chmod -cRf a-x,a+rX,u+w,g-w,o-w .
# after these make main file executable


jobs:
build-fedora:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this actually needs to be built in Fedora, not on Ubuntu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not need any specific packages for separate build this project in Fedora.

@guard43ru guard43ru requested a review from Serg-Norseman August 4, 2023 01:47
Terminal=false
Type=Application
Categories=Office
StartupNotify=true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of copying an already existing file here? Why maintain two files with identical content?

Copy link
Owner

@Serg-Norseman Serg-Norseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Serg-Norseman Serg-Norseman requested a review from hazzik August 4, 2023 13:14
@Serg-Norseman Serg-Norseman marked this pull request as ready for review August 4, 2023 13:39
@Serg-Norseman Serg-Norseman merged commit be028b6 into Serg-Norseman:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants