Build GKv3 installer (DMG) for MacOS #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
commented
Apr 17, 2023
| @@ -25,3 +25,6 @@ csharp_new_line_before_finally = false | |||
| [*.{md,yml}] | |||
| indent_style = space | |||
| indent_size = 2 | |||
|
|
|||
| [*.sh] | |||
| end_of_line = lf | |||
There was a problem hiding this comment.
VS Code refused to save .sh files with LF without this configuration
| - name: Build | ||
| run: dotnet build -c MacOS_Debug -p:EnableDmgBuild=true | ||
| working-directory: projects/GKv3 | ||
| - name: Upload DMG file |
There was a problem hiding this comment.
It crates an artifact that can be downloaded from Actions tab (Actions -> 'Package GEDKeeper 3 for MacOS' -> workflow run, at the bottom of 'Summary' page). Then it can be downloaded from there and distributed as a normal release file.
| # For details how to create a proper DMG HSF+ file see here: https://stackoverflow.com/a/7553878/259946. | ||
| # The ISO9660/HFS is a supported format for DMG files and can be treated as uncompressed DMG. | ||
|
|
||
| # sudo apt install mkisofs |
There was a problem hiding this comment.
mkisofs/genisoimage produces ISO-9660 that is a valid DMG file that can be mounted on MacOS. See the link above how to make a compressed DMG file from ISO.
| @@ -1,8 +1,8 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| <configuration default="false" name="GEDKeeper3.Mac" type="DotNetProject" factoryName=".NET Project"> | |||
| <option name="EXE_PATH" value="$PROJECT_DIR$/GEDKeeper3/bin/MacOS_Debug/net6.0/GEDKeeper3.app/Contents/MacOS/GEDKeeper3" /> | |||
There was a problem hiding this comment.
This has changed because now we have a single target framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a GitHub action that produces DMG installer containing unified (x64/arm64) build of the GEDKeeper3, that should run on both x64 (I've checked it works) and arm64 (Apple Silicon M1/M2 - I unfortunately do not have one, so could not check).
Because the DMG file are unsigned after download when it is tried to be opened it produces the "App Is Damaged and Can’t Be Opened" warning. See here for the information why this is happening and how to fix it.
TL;DR; Remove the
com.apple.quarantineattribute after installation:xattr -d com.apple.quarantine /Applications/GEDKeeper3.app