Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Some cleanups by moving /res folders to /usr/share and removing some useless config files #25606

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bplaat
Copy link
Member

@bplaat bplaat commented Dec 30, 2024

These commits clean up the /res and /home/anon/.config folders a bit.

All application specific non graphic files need to exist in /usr/share and not in /res so I moved them. Only /res/ladybird remains but that folder is special in the build system and would require a larger refactor.

Also where there some all default config files which could easily be removed, they are created on the fly when settings are changed.

Some files in /home/anon/.config to be moved to a more global dir, for better multi user support but I'll look into that in the future.

@bplaat bplaat requested a review from alimpfard as a code owner December 30, 2024 19:45
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 30, 2024
@bplaat bplaat changed the title Base: Soms cleanups by moving /res folders to /usr/share and removing some useless config files Base: Some cleanups by moving /res folders to /usr/share and removing some useless config files Dec 30, 2024
@alimpfard
Copy link
Member

I'm not entirely sure about the motivation here, but leaving that bit aside, I personally like having config files that specify the default behaviour instead of having them hidden in the code.

@bplaat
Copy link
Member Author

bplaat commented Dec 31, 2024

The default values must are already be in the code, so the files are not needed. In the end we need to move all the files out of the anon home folder because it won't work when creating other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 pr-needs-review PR needs review from a maintainer or community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants