Ports: Add missing dependency on ncurses to bash

[butter1125]

No description provided.

[timschumi]

I built bash countless times and it always seems to have worked just fine without ncurses. Are we sure that this is necessary?

[butter1125]

I just confirmed again it does indeed not work on my machine.

[bash/build] rm -f bash
[bash/build] x86_64-pc-serenity-gcc -L./builtins -L./lib/readline -L./lib/readline -L./lib/glob -L./lib/tilde  -L./lib/sh  -L./lib/termcap  -g -O2   -o bash shell.o eval.o y.tab.o general.o make_cmd.o print_cmd.o  dispose_cmd.o execute_cmd.o variables.o copy_cmd.o error.o expr.o flags.o jobs.o subst.o hashcmd.o hashlib.o mailcheck.o trap.o input.o unwind_prot.o pathexp.o sig.o test.o version.o alias.o array.o arrayfunc.o assoc.o braces.o bracecomp.o bashhist.o bashline.o  list.o stringlib.o locale.o findcmd.o redir.o pcomplete.o pcomplib.o syntax.o xmalloc.o signames.o -lbuiltins -lglob -lsh -lreadline -lhistory ./lib/termcap/libtermcap.a -ltilde     -ldl 
[bash/build] /home/ali/serenity/Toolchain/Local/x86_64/lib/gcc/x86_64-pc-serenity/13.2.0/../../../../x86_64-pc-serenity/bin/ld: ./lib/termcap/libtermcap.a(termcap.o):/home/ali/serenity/Build/x86_64/Ports/bash/bash-5.2.37/lib/termcap/termcap.c:298: multiple definition of `PC'; ./lib/readline/libreadline.a(terminal.o):/home/ali/serenity/Build/x86_64/Ports/bash/bash-5.2.37/lib/readline/terminal.c:109: first defined here
[bash/build] /home/ali/serenity/Toolchain/Local/x86_64/lib/gcc/x86_64-pc-serenity/13.2.0/../../../../x86_64-pc-serenity/bin/ld: ./lib/termcap/libtermcap.a(tparam.o):/home/ali/serenity/Build/x86_64/Ports/bash/bash-5.2.37/lib/termcap/tparam.c:126: multiple definition of `BC'; ./lib/readline/libreadline.a(terminal.o):/home/ali/serenity/Build/x86_64/Ports/bash/bash-5.2.37/lib/readline/terminal.c:109: first defined here
[bash/build] /home/ali/serenity/Toolchain/Local/x86_64/lib/gcc/x86_64-pc-serenity/13.2.0/../../../../x86_64-pc-serenity/bin/ld: ./lib/termcap/libtermcap.a(tparam.o):/home/ali/serenity/Build/x86_64/Ports/bash/bash-5.2.37/lib/termcap/tparam.c:127: multiple definition of `UP'; ./lib/readline/libreadline.a(terminal.o):/home/ali/serenity/Build/x86_64/Ports/bash/bash-5.2.37/lib/readline/terminal.c:109: first defined here
[bash/build] collect2: error: ld returned 1 exit status
[bash/build] make: *** [Makefile:595: bash] Error 1
Error in step bash/build (status=2)

[butter1125]

Maybe a solution would be to install ncurses. Then at least this problem would go away.