Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileManager: Add GPS location map widget to image properties window #25593

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

bplaat
Copy link
Member

@bplaat bplaat commented Dec 28, 2024

I've have add basic GPS EXIF tags parsing in LibGfx, moved the MapWidget.cpp to a new lib LibMaps because there where some dependency issues when putting it in LibGUI. And I've add the GPS map widget to the FileManager image properties window

Screenshot

Screenshot 2024-12-28 at 20 33 34

I'm currently at 38c3 it was fitting to use that as an test image

CC @Hendiadyoin1 @LucasChollet

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 28, 2024
Copy link
Member

@LucasChollet LucasChollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love this! Having the map as a widget is super cool.

Userland/Libraries/LibGfx/ImageFormats/ImageDecoder.h Outdated Show resolved Hide resolved
Userland/Libraries/LibGfx/ImageFormats/JPEGLoader.cpp Outdated Show resolved Hide resolved
@bplaat bplaat force-pushed the image-geolocation-metadata branch from a0e6605 to 722ca72 Compare December 29, 2024 09:20
@bplaat bplaat force-pushed the image-geolocation-metadata branch from 722ca72 to 8b4b316 Compare December 29, 2024 09:41
Copy link
Collaborator

@kleinesfilmroellchen kleinesfilmroellchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, as I said before it looks really nice and is very useful!

Userland/Applications/FileManager/main.cpp Show resolved Hide resolved
@nico nico merged commit a24fb24 into SerenityOS:master Jan 7, 2025
15 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 7, 2025
@bplaat bplaat deleted the image-geolocation-metadata branch January 7, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants