ArgsParser: Allow applications to override version string #25534
Conversation
github-actions
bot
added
the
👀 pr-needs-review
|
What |
I think it is useful because not all the utilities' version number should be the same. The author of a particular utility can set a version to indicate how complete it is, is it POSIX compliant, etc. The default behaviour is still the same. This is opt in. Also, there was a FIXME. :) |
I would argue that this is hardly measurable in a version number.
A FIXME existing doesn't necessarily mean that it's entirely accurate, or that the suggested change can skip our "don't add dead code" rules. :^) |
| outln(file, Core::Version::read_long_version_string().release_value_but_fixme_should_propagate_errors()); | ||
| } | ||
|
|
||
| void ArgsParser::set_version(StringView const& version) |
There was a problem hiding this comment.
Regardless of the other ongoing discussion, it might be worth thinking about if we want some owning string type here instead.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions! |
github-actions
bot
removed
the
👀 pr-needs-review
No description provided.