LibSemVer: Propogate errors so we get an error instead of crashing

[ninadsachania]

No description provided.

[nico]

Thanks for the patch! It looks like these functions are in userland and just allocate fairly fall strings, so per #20405 the SemVer accessors allocating strings should just MUST() instead of release_value_but_fixme_...

I don't remember if the developer docs mention the current stance on error handling mentioned in that issue. If they don't yet, they should be updated to do so…

[ninadsachania]

Thanks for the patch! It looks like these functions are in userland and just allocate fairly fall strings, so per #20405 the SemVer accessors allocating strings should just MUST() instead of release_value_but_fixme_...

I don't remember if the developer docs mention the current stance on error handling mentioned in that issue. If they don't yet, they should be updated to do so…

Ahh, that makes so much sense. I also felt like some of these refactorings are making things ugly, but I was following the FIXMEs. I'll fix the patch.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!