Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuoteCommand: Getting it working again #1033

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

CommandMC
Copy link
Contributor

With these patches, /quote seems to work again (on a testing repo of mine, link).

I don't know the cause of #533 yet (an issue in the create-pull-request plugin repo points to missing authentication, link). Could someone with access to the public bot confirm that our issue is still valid?

Instead of trying to fetch a message with the ID of the application
command (?) just to then use it to get to its channel, we can just use
the channel on our interaction
New message IDs can be 19 characters long, and they may grow up to
2^64-1 (20 characters) in the future.
The plugin will actually throw `Error`s for a lot of failure states,
which weren't caught before
@bgianfo bgianfo merged commit f557de7 into SerenityOS:master Dec 19, 2023
2 checks passed
@bgianfo
Copy link
Member

bgianfo commented Dec 19, 2023

Thanks!

@CommandMC CommandMC deleted the fix/quote-command branch December 20, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants