Feature/fix webhook #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description / Link to Ticket
This pull request releases version 2.8.4 of the
zai_paymentgem, focusing on fixing the webhook resource to use the correct API endpoint. The main change ensures that webhook-related requests are consistent with other resources by using thecore_baseendpoint.Webhook Resource Endpoint Fix:
webhooksaccessor inlib/zai_payment.rbto instantiateResources::Webhookwith a client usingbase_endpoint: :core_base, instead of the previousva_base. This aligns webhook API requests with the pattern used by other resources, ensuring consistency and correctness.Release and Versioning:
2.8.4inlib/zai_payment/version.rb.changelog.md, describing the webhook endpoint fix and providing a link to the full changelog.Testing
Additional Notes