Skip to content

Conversation

@eddyjaga
Copy link
Collaborator

@eddyjaga eddyjaga commented Nov 3, 2025

Short Description / Link to Ticket

This pull request updates the wallet account API response handling to better match the actual API structure, improves the consistency and usability of the Response#data method, and enhances documentation and test coverage for wallet accounts. The changes ensure that wallet account details are automatically and consistently extracted, making it easier for developers to access wallet information directly. Documentation and tests have also been updated to reflect these improvements.

Wallet Account Response Improvements

  • Updated the wallet account response structure to match the actual API, now returning a nested wallet_accounts object with all relevant fields and related resource links. The Response#data method now automatically extracts the wallet_accounts object for direct access to wallet fields. [1] [2] [3]
  • Improved API consistency: developers can now access wallet fields directly via response.data['balance'] instead of response.data['wallet_accounts']['balance']. [1] [2]

Documentation Updates

  • Updated docs/users.md and code comments to document the new wallet account structure, provide example usage, and clarify the automatic data extraction behavior. [1] [2] [3]

Test Enhancements

  • Expanded the wallet account test suite to cover all fields, including active status, timestamps, and all related links, ensuring comprehensive validation and maintainability. [1] [2] [3]

Version Bump

  • Bumped gem version to 2.6.1 to reflect these changes. [1] [2]

Testing

Additional Notes

@eddyjaga eddyjaga merged commit 06c8c18 into main Nov 3, 2025
2 checks passed
@eddyjaga eddyjaga deleted the feature/fix-bug-for-wallet-account branch November 3, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants