Skip to content

Conversation

@eddyjaga
Copy link
Collaborator

@eddyjaga eddyjaga commented Nov 3, 2025

Short Description / Link to Ticket

This pull request introduces comprehensive support for managing bank accounts within the ZaiPayment Ruby client, specifically targeting Australian and UK accounts. It adds a new BankAccount resource with full CRUD operations, robust validation, and routing number verification, along with extensive documentation and examples. The update also increases test coverage and updates the gem version to 2.5.0.

New Bank Account Resource:

  • Added the BankAccount resource (lib/zai_payment/resources/bank_account.rb) with methods for showing, creating (AU/UK), redacting, and validating bank accounts, including support for decrypted sensitive fields and detailed validation for account and holder types, country codes, and required fields.
  • Integrated the new resource into the main client (lib/zai_payment.rb) and exposed it via ZaiPayment.bank_accounts. [1] [2]
  • Updated the response parser to support routing number validation responses.

Documentation and Examples:

  • Added a comprehensive changelog entry for v2.5.0, detailing all new features and improvements related to bank accounts.
  • Expanded the readme.md to document bank account management, increased test coverage stats, and updated feature tables to reflect the new functionality. [1] [2]
  • Reorganized and clarified usage sections in the README for users and items, and added dedicated sections for bank accounts. [1] [2]

Versioning:

  • Bumped the gem version to 2.5.0 to reflect the new feature release.

Testing

Additional Notes

@eddyjaga eddyjaga requested a review from Copilot November 3, 2025 02:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive bank account management functionality to the ZaiPayment gem (v2.5.0), including support for Australian and UK bank accounts with full CRUD operations and routing number validation.

Key changes:

  • Implements BankAccount resource with methods for show, create (AU/UK), redact, and validate routing numbers
  • Adds support for decrypted field retrieval, account type/holder type validation, and region-specific requirements
  • Provides extensive documentation and examples with 25+ test cases

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lib/zai_payment/resources/bank_account.rb Core BankAccount resource implementation with validation logic and API methods
spec/zai_payment/resources/bank_account_spec.rb Comprehensive test suite covering all bank account operations and edge cases
lib/zai_payment/response.rb Adds routing_number to response data keys for routing validation
lib/zai_payment.rb Registers bank_accounts resource accessor
readme.md Updates features list, test coverage (97%+), and documentation links
docs/bank_accounts.md Complete API documentation with examples and validation rules
examples/bank_accounts.md Real-world usage patterns and integration examples
changelog.md Documents v2.5.0 release with bank account features
lib/zai_payment/version.rb Version bump to 2.5.0
Gemfile.lock Updates version reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sentia Sentia deleted a comment from Copilot AI Nov 3, 2025
@eddyjaga eddyjaga merged commit d873a4d into main Nov 3, 2025
2 checks passed
@eddyjaga eddyjaga deleted the feature/bank-account branch November 3, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants