2025-04-24 mariadb - old-menu branch - PR 2 of 2 #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Dockerfile syntax deprecates `ENV key value` in favour of `ENV key=value`. 2. Adjust health-check script to deal with two problems: a. An issue where `MYSQL_ROOT_PASSWORD` does not result in a root password being set on a newly-initialised database. See [docker-mariadb issue 163](linuxserver/docker-mariadb#163) b. Steady deprecation of `mysqladmin` in favour of `mariadb-admin`. Signed-off-by: Phill Kelley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile syntax deprecates
ENV key valuein favour ofENV key=value.Adjust health-check script to deal with two problems:
a. An issue where
MYSQL_ROOT_PASSWORDdoes not result in a rootpassword being set on a newly-initialised database.
See docker-mariadb issue 163
b. Steady deprecation of
mysqladminin favour ofmariadb-admin.