Skip to content

[NV] H100 (Agg): migrate model path #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ankur-singh wants to merge 2 commits into
base: main
Choose a base branch
from

h100(agg): migrate model path to /mnt/numa1/shared/models/, drop hf d…

ce884ce
Select commit
Loading
Failed to load commit list.
Open

[NV] H100 (Agg): migrate model path #1537

h100(agg): migrate model path to /mnt/numa1/shared/models/, drop hf d…
ce884ce
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 20, 2026 in 7m 8s

Code review found 1 important issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important perf-changelog.yaml:3063 perf-changelog: pr-link placeholder XXXX not replaced

Annotations

Check failure on line 3063 in perf-changelog.yaml

See this annotation in the file changed.

@claude claude / Claude Code Review

perf-changelog: pr-link placeholder XXXX not replaced 

The new perf-changelog entry at line 3063 has `pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXXX` — the literal placeholder `XXXX` was never replaced with the real PR number (1537). Every other recent entry in the file uses a real PR id, and per AGENTS.md this file is the audit trail linking config changes back to the PR that triggered them. Please replace `XXXX` with `1537` before merging.
View more details on Claude