feat(gpu-graph): date line labels on GPU comparison rooflines#288
Merged
Conversation
The "Line Labels" toggle is now available on the GPU config / comparison-date dashboard graph too, sharing the same showLineLabels state as the scatter chart. Each visible (date, hwKey) roofline gets exactly one label rendered along it — text is the **date** rather than the hw config, since the legend already carries the hw identity in its grouping and color, and date is the dimension that distinguishes series within a single GPU comparison view. Implementation mirrors ScatterGraph: a custom layer dedupes per (date, hwKey) by picking the longest roofline, runs greedy collision avoidance on the interactivity chart (try start → midpoint → 2/3 → endpoint) and falls back to spaced-out endpoint labels for TTFT / E2EL. Zoom updates labels in lockstep with the rooflines. Labels respect the activeDates legend filter so toggling a series off hides its label. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Each line label now reads "<hw display label> • <date>" so the chart is self-contained — the user no longer has to cross-reference the legend's hw grouping to know which roofline is which GPU. Bumps LABEL_W from 90 to 160 to give the wider labels enough horizontal breathing room in the collision-avoidance pass. Component test asserts both the date strings and the hw display labels appear. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
lalithsagar10
pushed a commit
to lalithsagar10/InferenceX-app
that referenced
this pull request
May 5, 2026
…alysisAI#288) * feat(gpu-graph): add date line labels to GPU comparison rooflines The "Line Labels" toggle is now available on the GPU config / comparison-date dashboard graph too, sharing the same showLineLabels state as the scatter chart. Each visible (date, hwKey) roofline gets exactly one label rendered along it — text is the **date** rather than the hw config, since the legend already carries the hw identity in its grouping and color, and date is the dimension that distinguishes series within a single GPU comparison view. Implementation mirrors ScatterGraph: a custom layer dedupes per (date, hwKey) by picking the longest roofline, runs greedy collision avoidance on the interactivity chart (try start → midpoint → 2/3 → endpoint) and falls back to spaced-out endpoint labels for TTFT / E2EL. Zoom updates labels in lockstep with the rooflines. Labels respect the activeDates legend filter so toggling a series off hides its label. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(gpu-graph): include hw config in line label, not just the date Each line label now reads "<hw display label> • <date>" so the chart is self-contained — the user no longer has to cross-reference the legend's hw grouping to know which roofline is which GPU. Bumps LABEL_W from 90 to 160 to give the wider labels enough horizontal breathing room in the collision-avoidance pass. Component test asserts both the date strings and the hw display labels appear. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPUGraph), shared with the existingshowLineLabelsstate on the inference scatter chart.(date, hwKey)roofline gets exactly one label rendered along it. Label text is the date rather than the hw config — the legend already groups by hw and the date is the dimension that distinguishes series within a single GPU comparison view.(date, hwKey)by picking the longest roofline, runs greedy collision avoidance on the interactivity chart (try start → midpoint → 2/3 → endpoint), and falls back to spaced-out endpoint labels for TTFT / E2EL. Zoom updates labels in lockstep with the rooflines. Labels respect theactiveDateslegend filter so toggling a series off hides its label.Test plan
gpu-graph.cy.tsx"renders date line labels…" passes (asserts label count, contains date strings, omits hw labels).🤖 Generated with Claude Code