Skip to content

[py] Use daemon threads for WebSocket connections #16298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

[py] Use daemon threads for WebSocket connections #16298

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54175e0
[py] Use daemon threads for WebSocket connections
cgoldberg Sep 8, 2025
874daa1
Merge branch 'SeleniumHQ:trunk' into py-daemon-threads
cgoldberg Sep 8, 2025
67774a7
Merge branch 'SeleniumHQ:trunk' into py-daemon-threads
cgoldberg Sep 10, 2025
5117949
Merge branch 'SeleniumHQ:trunk' into py-daemon-threads
cgoldberg Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/selenium/webdriver/remote/websocket_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def run_socket():
self._ws.run_forever(suppress_origin=True)

self._ws = WebSocketApp(self.url, on_open=on_open, on_message=on_message, on_error=on_error)
self._ws_thread = Thread(target=run_socket)
self._ws_thread = Thread(target=run_socket, daemon=True)
self._ws_thread.start()

def _process_message(self, message):
Expand All @@ -139,7 +139,7 @@ def _process_message(self, message):
if "method" in message:
params = message["params"]
for callback in self.callbacks.get(message["method"], []):
Thread(target=callback, args=(params,)).start()
Thread(target=callback, args=(params,), daemon=True).start()

def _wait_until(self, condition):
timeout = self._response_wait_timeout
Expand Down