Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable min/max replica for Server CR #6218

Merged
merged 19 commits into from
Jan 22, 2025

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Jan 21, 2025

What this PR does / why we need it:

This PR adds scaffolding code to deal with Min/Max replica for a given server from within the scheduler. This is essentially required for follow-up work to add server autoscaling as part of the system. Work done mostly by @lc525

One particular change is to introduce Type in ServerStatusResponse to differential between the "normal" flow of server status updates vs. triggered (to follow) for scaling servers up/down.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
TODO:

  • Unit tests review

@sakoush sakoush added the v2 label Jan 21, 2025
@sakoush sakoush requested a review from driev January 21, 2025 17:12
@sakoush sakoush marked this pull request as ready for review January 21, 2025 17:13
@sakoush sakoush requested a review from lc525 as a code owner January 21, 2025 17:13
@sakoush sakoush merged commit 3b3e248 into SeldonIO:v2 Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants