forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 2
First version of LST in HLT with procModifiers #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
VourMa
wants to merge
23
commits into
CMSSW_14_1_0_pre7_LST_alpakaPatatrackInHLT
from
CMSSW_14_1_0_pre7_LST_alpakaPatatrackInHLT_LSTInHLT
Closed
First version of LST in HLT with procModifiers #91
VourMa
wants to merge
23
commits into
CMSSW_14_1_0_pre7_LST_alpakaPatatrackInHLT
from
CMSSW_14_1_0_pre7_LST_alpakaPatatrackInHLT_LSTInHLT
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters; need to write to CPU buffer asyncronously or directly only after a sync
…it-bugfix bugfixes to incomplete alpaka::wait cleanup (for batch6)
…TCore_realfiles_smallFixesPostBatch5 Small fixes post batch 5
More review fixes: smart pointers, cleaner namespaces, naming fixes
…TCore_realfiles_batch6 Batch 6 for updates to LST integration in cms-sw
…ecks/cms-sw-PR-45117/41778/code-format.patch; the result looks less readable, but we have to comply
Collaborator
Author
|
I have updated the code to a working version and I have included the running commands in the description (together with some explanatory text). |
Collaborator
Author
|
Superseded by #94 (this one was missing a few important LST updates on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This is a first version of a procModifier-based implementation of LST in HLT, based on top of
CMSSW_14_1_0_pre7+ cms-sw#45117 + cms-sw#45508. The target branch has been adapted accordingly to be able to make a clear comparison.It is an adaptation/improvement over #63, which becomes moot in terms of LST (also mkFit would need to be re-implemented with the usage of procModifiers from that PR).
It tries to reuse the
trackingLSTprocModifier, and it introduces a new one,seedingLST, which may become also useful for the offline setup in the near future. It may be that thealpakaprocModifier would need to be applied in conjunction with anything else (to be tested).The performance is not as expected, so the code is being debugged. However, the PR is already good enough for people to take a look and comment on the implementation details.
Instructions on how to run