-
Notifications
You must be signed in to change notification settings - Fork 2
test zPointed selection fix in PPBB #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
it looks like the window used in zPointed cut should not be scaled by dr/length(pLS)
|
/run gpu-all |
|
the history of the cut goes back to |
|
The PR was built and ran successfully with CMSSW on GPU. Here are some plots. OOTB All Tracks
The full set of validation and comparison plots can be found here. |
|
The PR was built and ran successfully in standalone mode on GPU. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. Here is a timing comparison: |
|
the change looks safe enough: there are almost no differences in the eff category plots So, I will include this in #213 |
|
@ariostas is it some accidental job scheduling issue the CI side and it just needs a restart or is there some issue with the CI setup? |
Hmm I'll take a look |
|
Oh yeah, there was a missing piece in the concurrency group. It's fixed now. |












it looks like the window used in zPointed cut should not be scaled by dr/length(pLS)