CPU vs. GPU for LST (and potentially more) in HLT #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slava77
reviewed
Dec 20, 2025
slava77
left a comment
slava77
left a comment
There was a problem hiding this comment.
I don't see alpakaValidationLST already added to the alpakaValidation chain.
Or is it logically not practical? (I didn't think all variants well enough).
It sounds like it can be done with no (?) cost. If it's chained by default:
- If the
trackingLSTis not in the producer side of the configuration, a clone of tracks would be compared. This is OK, but wasteful. - Alternatively
alpakaValidationLST & trackingLSTcould be used on the producer sequence and product addition side. This way if thetrackingLSTwas not specified we'd be leaving/allowing the validation module silently fail with empty/missing inputs. This will be lighter on the resources.
| @@ -12,3 +12,7 @@ | |||
| from Configuration.ProcessModifiers.seedingLST_cff import seedingLST | |||
| from Configuration.ProcessModifiers.hltTrackingMkFitInitialStep_cff import hltTrackingMkFitInitialStep | |||
| (trackingLST & seedingLST & hltTrackingMkFitInitialStep).toModify(hltInitialStepMkFitSeeds, seeds = "hltInitialStepTrajectorySeedsLST") | |||
|
|
|||
| hltInitialStepMkFitSeedsSerialSync = hltInitialStepMkFitSeeds.clone( | |||
There was a problem hiding this comment.
I thought the idea was to not cover the seedingLST part: just use the candidate directly from LST and only pass them through a fit
Comment on lines
+94
to
+96
| lstOutput = cms.InputTag('hltLSTSerialSync'), | ||
| lstInput = cms.InputTag('hltInputLSTSerialSync'), | ||
| lstPixelSeeds = cms.InputTag('hltInputLSTSerialSync') |
There was a problem hiding this comment.
Suggested change
| lstOutput = cms.InputTag('hltLSTSerialSync'), | |
| lstInput = cms.InputTag('hltInputLSTSerialSync'), | |
| lstPixelSeeds = cms.InputTag('hltInputLSTSerialSync') | |
| lstOutput = 'hltLSTSerialSync', | |
| lstInput = 'hltInputLSTSerialSync', | |
| lstPixelSeeds = 'hltInputLSTSerialSync' |
the usual thing with modifying existing parameters; the comment applies to the rest of the PR
| @@ -18,6 +18,10 @@ | |||
| useSimpleMF = cms.bool(False) | |||
| ) | |||
|
|
|||
| hltInitialStepTracksSerialSync = hltInitialStepTracks.clone( | |||
| src = cms.InputTag("hltInitialStepTrackCandidatesSerialSync"), | |||
There was a problem hiding this comment.
Suggested change
| src = cms.InputTag("hltInitialStepTrackCandidatesSerialSync"), | |
| src = "hltInitialStepTrackCandidatesSerialSync", |
| @@ -19,3 +19,9 @@ | |||
| forceKinematicWithRegionDirection = cms.bool(False) | |||
| ) | |||
| ) | |||
|
|
|||
| hltInitialStepTrajectorySeedsLSTSerialSync = hltInitialStepTrajectorySeedsLST.clone( | |||
| lstOutput = cms.InputTag('hltLSTSerialSync'), | |||
There was a problem hiding this comment.
Suggested change
| lstOutput = cms.InputTag('hltLSTSerialSync'), | |
| lstOutput = 'hltLSTSerialSync', |
| @@ -106,6 +115,8 @@ | |||
|
|
|||
| (singleIterPatatrack & trackingLST & seedingLST & hltTrackingMkFitInitialStep).toReplaceWith(HLTInitialStepSequence, _HLTInitialStepSequenceSingleIterPatatrackLSTSeedingMkFitTracking) | |||
|
|
|||
| #(alpakaValidation & singleIterPatatrack & trackingLST & seedingLST & hltTrackingMkFitInitialStep).toReplaceWith(HLTInitialStepSequence, HLTInitialStepSequence.copyAndAdd([hltInputLSTSerialSync,hltLSTSerialSync,hltInitialStepTrajectorySeedsLSTSerialSync,hltInitialStepTrackCandidatesSerialSync,hltInitialStepTracksSerialSync])) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serial sync reconstruction and comparison plots implemented with a procModifier
alpakaValidationLST.Currently only implemented for the procModifier combination:
alpakaValidationLST,singleIterPatatrack,trackingLSTbut the new baseline is to be supported as well, once the technical details are worked out.
The current issue is that after the harvesting step the histograms appear but are empty. The needed collections (properly filled) appear after the HLT step.
Another idea is to have also track to track comparison for the pixel tracks (but that's a bonus, not sure if we want it).
Once the HLT config is working, I will also propagate the same modifier to the offline workflow.