Skip to content

feat: add GPT-5 reasoning model support #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vorniches wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add GPT-5 reasoning model support #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions VirtualHavruta/vh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,23 @@ def initialize_llm_instances(self):
if model_name.startswith(('main', 'support')):
model_kwargs = {"response_format": {"type": "json_object"}} if model_name.endswith('_json') else {}
model_key = model_name.replace('_json', '') # Removes the '_json' suffix for lookup in model_api
setattr(self, model_name, ChatOpenAI(
temperature=self.model_api.get(f"{model_key}_temperature", None),
model=self.model_api.get(model_key, None),
model_kwargs=model_kwargs
))
current_model = self.model_api.get(model_key, None)

if current_model and 'gpt-5' in current_model:
# GPT-5 models: use reasoning instead of temperature
reasoning_effort = self.model_api.get(f"{model_key}_reasoning_effort", "minimal")
setattr(self, model_name, ChatOpenAI(
model=current_model,
reasoning={"effort": reasoning_effort},
model_kwargs=model_kwargs
))
else:
# Legacy models: use temperature
setattr(self, model_name, ChatOpenAI(
temperature=self.model_api.get(f"{model_key}_temperature", None),
model=current_model,
model_kwargs=model_kwargs
))
self.initialize_llm_chains(getattr(self, model_name), suffixes)

def initialize_llm_chains(self, model, suffixes):
Expand Down