Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue 555 - Improve UX navigating across DEL button (expanding it) #603

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'dev' into resolves_issue_555
fedebuyito authored Dec 30, 2024
commit c249d4a3bfef054a0268745dfa38146641aa8147
11 changes: 7 additions & 4 deletions src/seedsigner/gui/keyboard.py
Original file line number Diff line number Diff line change
@@ -42,28 +42,31 @@ class Keyboard:
}
KEY_BACKSPACE_2 = {
"code": "DEL",
"letter": "del",
"letter": del_label,
"font": COMPACT_KEY_FONT,
"size": 2,
}
KEY_BACKSPACE_4 = {
"code": "DEL",
"letter": "del",
"letter": del_label,
"font": COMPACT_KEY_FONT,
"size": 4,
}
KEY_BACKSPACE_5 = {
"code": "DEL",
"letter": "del",
"letter": del_label,
"font": COMPACT_KEY_FONT,
"size": 5,
}
KEY_BACKSPACE_6 = {
"code": "DEL",
"letter": "del",
"letter": del_label,
"font": COMPACT_KEY_FONT,
"size": 6,
}

# TRANSLATOR_NOTE: The abbreviated label for the special key <space> on a standard keyboard.
space_label = _("space")
KEY_SPACE = {
"code": "SPACE",
"letter": space_label,
9 changes: 5 additions & 4 deletions src/seedsigner/gui/screens/tools_screens.py
Original file line number Diff line number Diff line change
@@ -134,8 +134,8 @@ def _run(self):
class ToolsDiceEntropyEntryScreen(KeyboardScreen):

def __post_init__(self):
# Override values set by the parent class
self.title = f"Dice Roll 1/{self.return_after_n_chars}"
# TRANSLATOR_NOTE: current roll number vs total rolls (e.g. roll 7 of 50)
self.title = _("Dice Roll {}/{}").format(1, self.return_after_n_chars)
self.custom_additional_keys = [Keyboard.KEY_BACKSPACE]

# Specify the keys in the keyboard
@@ -196,9 +196,10 @@ def __post_init__(self):
class ToolsCoinFlipEntryScreen(KeyboardScreen):
def __post_init__(self):
# Override values set by the parent class
self.title = f"Coin Flip 1/{self.return_after_n_chars}"
# TRANSLATOR_NOTE: current coin-flip number vs total flips (e.g. flip 3 of 4)
self.title = _("Coin Flip {}/{}").format(1, self.return_after_n_chars)
self.custom_additional_keys = [Keyboard.KEY_BACKSPACE_2]

# Specify the keys in the keyboard
self.rows = 1
self.cols = 4
You are viewing a condensed version of this merge commit. You can view the full changes here.