fix: reject inverted budget ranges in createJobSchema#3367
Open
AlvaroWhiteRD wants to merge 1 commit into
Open
fix: reject inverted budget ranges in createJobSchema#3367AlvaroWhiteRD wants to merge 1 commit into
AlvaroWhiteRD wants to merge 1 commit into
Conversation
- Extract base schema to allow refinement on both create and update schemas - Add refine check ensuring budgetMax >= budgetMin when both fields present - updateJobSchema (partial) also validates range when both budget fields provided - Add 8 regression tests covering valid ranges, inverted ranges, equal values, partial updates, and missing fields Closes SecureBananaLabs#2853
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
createJobSchemaaccepts payloads wherebudgetMaxis lower thanbudgetMin, creating invalid job records (e.g. $500-100 budget range).Solution
.refine()check ensuringbudgetMax >= budgetMinwhen both fields are presentupdateJobSchema(partial) also validates the range when both budget fields are providedTest Results
All 9 tests pass (8 new + 1 existing health test).
Files Changed
apps/api/src/validators/job.js— Added budget range refinementapps/api/src/tests/job.test.js— New test file (8 tests)Closes #2853