fix: count malformed json requests in rate limiter#3366
Open
vicentsmith470-web wants to merge 1 commit into
Open
fix: count malformed json requests in rate limiter#3366vicentsmith470-web wants to merge 1 commit into
vicentsmith470-web wants to merge 1 commit into
Conversation
Author
|
Added the short demo video requested by the bounty instructions to the PR body: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3365
/claim #743
Validation
node --check apps/api/src/app.jsnode --check apps/api/src/tests/rateLimit.test.jsnode --test apps/api/src/tests/rateLimit.test.jsnode --test apps/api/src/tests/health.test.js apps/api/src/tests/rateLimit.test.jsgit diff --checkDemo Video
The regression test exercises the API over a real ephemeral HTTP server: 201 malformed JSON
POST /api/jobsrequests from the same client, with the final response asserted as HTTP 429.