fix(lhf-003): prevent self-registration as admin#3352
Open
patchninja-my wants to merge 1 commit into
Open
Conversation
- Remove 'admin' from public registration schema - Admin role assignment must go through a separate privileged endpoint - Fixes security issue where any user could gain admin access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
🟠 LHF-003: Registration schema allows self-assignment of admin role
What changed
Removed
"admin"fromroleenum inregisterSchema.Before/After
Before:
role: z.enum(["client", "freelancer", "admin"])After:
role: z.enum(["client", "freelancer"])Bounty Claim
/bounty $100
Wallet: TRON
TKaPPxtvKDfMJkset12MzEhrF9hwrtmMPiCloses #3357