Skip to content

fix: keep new notifications unread on creation#3339

Open
Barroso0 wants to merge 1 commit into
SecureBananaLabs:mainfrom
Barroso0:codex/notification-read-default-3334
Open

fix: keep new notifications unread on creation#3339
Barroso0 wants to merge 1 commit into
SecureBananaLabs:mainfrom
Barroso0:codex/notification-read-default-3334

Conversation

@Barroso0
Copy link
Copy Markdown

@Barroso0 Barroso0 commented Jun 1, 2026

/claim #743

Closes #3334
References #743

Summary

  • prevent caller payloads from overriding the unread default during notification creation
  • add a focused regression test proving read: true in the payload still returns and stores read: false

Demo / verification

  • Failing before the fix: node --test src/tests/notification.test.js produced true !== false
  • node --test src/tests/notification.test.js
  • node --test src/tests/*.js
  • git diff --check

Note: npm test -w apps/api still fails in this Node 24 environment because the existing package script invokes node --test src/tests as a directory path; explicit test globs above pass with dependencies installed.

AI-assisted with Codex; I reviewed the diff and local verification before opening this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification creation should ignore client-supplied read state

1 participant