Upload endpoint lacks authentication — unauthenticated file uploads allowed#3330
Open
cyrillical00 wants to merge 1 commit into
Conversation
Summary: Add authMiddleware to the upload route and create apps/api/package.json so the workspace is recognized by npm. Reasoning: The prior patch correctly added authMiddleware to the upload POST route, and it applied cleanly. The test failure was caused by npm not finding the apps/api workspace because no package.json existed there. Adding a minimal package.json with name 'api' makes npm recognize it as a workspace. The route fix itself is the security fix: unauthenticated requests will now be rejected by authMiddleware before reaching the multer/uploadFile handlers. Top blockers: The authMiddleware file at apps/api/src/middleware/authMiddleware.js was not shown; assuming it exists and exports authMiddleware as the codebase implies. Drafted by bounty-bot for SecureBananaLabs#1771
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the bounty.
Summary
Summary: Add authMiddleware to the upload route and create apps/api/package.json so the workspace is recognized by npm.
Reasoning: The prior patch correctly added authMiddleware to the upload POST route, and it applied cleanly. The test failure was caused by npm not finding the apps/api workspace because no package.json existed there. Adding a minimal package.json with name 'api' makes npm recognize it as a workspace. The route fix itself is the security fix: unauthenticated requests will now be rejected by authMiddleware before reaching the multer/uploadFile handlers.
Top blockers: The authMiddleware file at apps/api/src/middleware/authMiddleware.js was not shown; assuming it exists and exports authMiddleware as the codebase implies.
Test commands
npm installnpm run test -w apps/apiSubmitted via bounty-bot. Confidence: medium.