[codex] add server-owned job creation timestamps#3315
Open
TheGreatAion wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createdAttimestamp when jobs are createdWhy
The Prisma
Jobmodel definescreatedAt, but the in-memorycreateJobservice omitted it. This left newly created records without creation metadata and allowed a caller-suppliedcreatedAtvalue to flow through the payload spread.Demo
Watch the short job timestamp demo
Verification
node --test src/tests/health.test.js src/tests/job-created-at.test.jsgit diff --checkffmpeg -i job-created-at-demo.mp4 -f null -The repository-wide
npm testcommand still fails before discovery becausenode --test src/teststreats the test directory as a module path. That inherited harness issue is already tracked separately in #2014.Closes #3313
/claim #743