Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tweaks? #1

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

gilgongo
Copy link
Collaborator

@gilgongo gilgongo commented Oct 6, 2024

I'm not familiar with the tooling (or the architecture in general) but thought I'd have a look. In the course of which, I made some changes which are probably rather messy...

Apart from the obvious tinkering with sizing, density, colours and texture:

  1. New (Google) fonts: Fjalla One for hero, Afacad Flux for the rest (not sure what the logotype is but it's similar).
  2. Switched out the Services carousel for the grid because on mobile at first might look like you only did social media?
  3. Added/updates alt text to all images.
  4. Reduced width of mobile side nav as you have to tap the background to dismiss it. Not sure how to fix that.
  5. Added favicon (after some hassle!)

Would have liked to have experimented with the background wave colour, but couldn't work out how. The new hero text colour contrast is the same as the original (only just gets WCAG AA) - green and gold?

I got stuck on:

  • How to remove duplicate footer on home page.
  • How to scale properly on mobile. Something's giving it a minimum width?

It may all be too crazy to merge :-), but it would be nice to at least add the favicon display the services in a grid on the home page.

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for coruscating-kashata-45488f ready!

Name Link
🔨 Latest commit 9b0f9fa
🔍 Latest deploy log https://app.netlify.com/sites/coruscating-kashata-45488f/deploys/67025358c807a50008a5c20f
😎 Deploy Preview https://deploy-preview-1--coruscating-kashata-45488f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SebastianStankiewicz
Copy link
Owner

Thank you very much for the help and useful insight.

The repo might be a bit messy since I’m still learning a lot, so I apologise if it’s not up to industry standards or is a little difficult to navigate.

The background waves are SVG files and had an issue when running the build script with none of my SVG's appearing. A solution was copying everything under the public directory. Eg the wave for the "hero" component can be found navigating under "public/graphics/heroGraphic.svg" and adjusting the RGB values manually to change the colour.

Ive viewed and really like your changes via the previewed deployment. I see what you mean about the duplicate footer and mobile scaling. I can look at fixing this tomorrow before merging?

@gilgongo
Copy link
Collaborator Author

gilgongo commented Oct 7, 2024

Thanks - I'm really not experienced in any of this! I'm sure the repo's all fine - just didn't want to make it unintentionally harder to maintain. The mobile scaling isn't that big a deal, so don't worry if it can't be perfect, but I hope the duplicate footer would be an easier to fix.

@SebastianStankiewicz
Copy link
Owner

Sorry been absolutely swamped with uni work! Will be on this ASAP when Ive cleared my assignments. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants