-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various tweaks? #1
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for coruscating-kashata-45488f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you very much for the help and useful insight. The repo might be a bit messy since I’m still learning a lot, so I apologise if it’s not up to industry standards or is a little difficult to navigate. The background waves are SVG files and had an issue when running the build script with none of my SVG's appearing. A solution was copying everything under the public directory. Eg the wave for the "hero" component can be found navigating under "public/graphics/heroGraphic.svg" and adjusting the RGB values manually to change the colour. Ive viewed and really like your changes via the previewed deployment. I see what you mean about the duplicate footer and mobile scaling. I can look at fixing this tomorrow before merging? |
Thanks - I'm really not experienced in any of this! I'm sure the repo's all fine - just didn't want to make it unintentionally harder to maintain. The mobile scaling isn't that big a deal, so don't worry if it can't be perfect, but I hope the duplicate footer would be an easier to fix. |
Sorry been absolutely swamped with uni work! Will be on this ASAP when Ive cleared my assignments. Sorry for the delay. |
I'm not familiar with the tooling (or the architecture in general) but thought I'd have a look. In the course of which, I made some changes which are probably rather messy...
Apart from the obvious tinkering with sizing, density, colours and texture:
Would have liked to have experimented with the background wave colour, but couldn't work out how. The new hero text colour contrast is the same as the original (only just gets WCAG AA) - green and gold?
I got stuck on:
It may all be too crazy to merge :-), but it would be nice to at least add the favicon display the services in a grid on the home page.