feat: ExceptionStatement raises custom SQL errors #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gronke
force-pushed
the
custom-errors
branch
from
cef173e to
c9246bf
Compare
Expurple
reviewed
May 16, 2025
| @@ -35,6 +35,7 @@ pub enum SimpleExpr { | |||
| AsEnum(DynIden, Box<SimpleExpr>), | |||
| Case(Box<CaseStatement>), | |||
| Constant(Value), | |||
| Exception(ExceptionStatement), | |||
There was a problem hiding this comment.
You should mention that this is a breaking change (adding a new variant to a public enum not marked as #[non_exhaustive]).
Perhaps, we should add #[non_exhaustive] in the next major version. That's also a breaking change. But after that, changes like yours can me merged anytime with no problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Allows defining SQL errors, for instance in an
IfElseStatement#828 inside aTriggerStatement#824 that rejects an update on certain conditions.New Features
ExceptionStatementraises custom SQL errorsBreaking Changes
SimpleExpr:: Exceptionvariant to public enum