fix: reject passwords over bcrypt byte limit#998
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This is ready for review. If the repo uses GSSoC scoring labels, please apply the appropriate approval/level label when convenient. The fix is validated with targeted pytest runs for auth and change-password. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #932\n\nSummary:\n- reject passwords over bcrypt's 72-byte bcrypt limit in the shared password validator\n- keep registration and change-password paths on the shared validation path\n- add regressions for register and change-password using a UTF-8 password over 72 bytes\n\nValidation:\n- git diff --check\n- /Users/saurabhkumarbajpaiai/.cache/codex-runtimes/codex-primary-runtime/dependencies/python/bin/python3 -m pytest backend/tests/test_auth.py backend/tests/test_change_password.py -q