Skip to content

fix: reject passwords over bcrypt byte limit#998

Open
saurabhhhcodes wants to merge 1 commit into
SdSarthak:mainfrom
saurabhhhcodes:fix/password-byte-limit-932
Open

fix: reject passwords over bcrypt byte limit#998
saurabhhhcodes wants to merge 1 commit into
SdSarthak:mainfrom
saurabhhhcodes:fix/password-byte-limit-932

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Closes #932\n\nSummary:\n- reject passwords over bcrypt's 72-byte bcrypt limit in the shared password validator\n- keep registration and change-password paths on the shared validation path\n- add regressions for register and change-password using a UTF-8 password over 72 bytes\n\nValidation:\n- git diff --check\n- /Users/saurabhkumarbajpaiai/.cache/codex-runtimes/codex-primary-runtime/dependencies/python/bin/python3 -m pytest backend/tests/test_auth.py backend/tests/test_change_password.py -q

@saurabhhhcodes

Copy link
Copy Markdown
Contributor Author

This is ready for review. If the repo uses GSSoC scoring labels, please apply the appropriate approval/level label when convenient. The fix is validated with targeted pytest runs for auth and change-password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verify_password silently rejects passwords >72 bytes

2 participants