Skip to content

Fix/alembic migration idempotent #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cosmoqain459 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix/alembic migration idempotent #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25127fe
Improve scan prompt tests with payload verification
cosmoqain459 May 30, 2026
02d2e66
refactor(test): improve document generation test suite
cosmoqain459 Jun 1, 2026
895e006
fix: make alembic migrations idempotent with if_not_exists
cosmoqain459 Jun 6, 2026
c0f2c69
chore: revert unrelated test changes
cosmoqain459 Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions backend/alembic/versions/55a49e4b7bc8_add_webhook_configs_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ def upgrade() -> None:
sa.Column('updated_at', sa.DateTime(), nullable=True),
sa.ForeignKeyConstraint(['user_id'], ['users.id'], ),
sa.PrimaryKeyConstraint('id'),
if_not_exists=True,
)
op.create_index(op.f('ix_webhook_configs_id'), 'webhook_configs', ['id'], unique=False)
op.create_index(op.f('ix_webhook_configs_id'), 'webhook_configs', ['id'], unique=False, if_not_exists=True)


def downgrade() -> None:
op.drop_index(op.f('ix_webhook_configs_id'), table_name='webhook_configs')
op.drop_table('webhook_configs')
op.drop_index(op.f('ix_webhook_configs_id'), table_name='webhook_configs', if_exists=True)
op.drop_table('webhook_configs', if_exists=True)
9 changes: 5 additions & 4 deletions backend/alembic/versions/a7c004156ad1_add_ai_system_audit_logs_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,15 @@ def upgrade() -> None:
sa.Column('changed_at', sa.DateTime(), nullable=True),
sa.ForeignKeyConstraint(['ai_system_id'], ['ai_systems.id'], ),
sa.ForeignKeyConstraint(['changed_by_id'], ['users.id'], ),
sa.PrimaryKeyConstraint('id')
sa.PrimaryKeyConstraint('id'),
if_not_exists=True,
)
op.create_index(op.f('ix_ai_system_audit_logs_id'), 'ai_system_audit_logs', ['id'], unique=False)
op.create_index(op.f('ix_ai_system_audit_logs_id'), 'ai_system_audit_logs', ['id'], unique=False, if_not_exists=True)
# ### end Alembic commands ###


def downgrade() -> None:
# ### commands auto generated by Alembic - please adjust! ###
op.drop_index(op.f('ix_ai_system_audit_logs_id'), table_name='ai_system_audit_logs')
op.drop_table('ai_system_audit_logs')
op.drop_index(op.f('ix_ai_system_audit_logs_id'), table_name='ai_system_audit_logs', if_exists=True)
op.drop_table('ai_system_audit_logs', if_exists=True)
# ### end Alembic commands ###
12 changes: 11 additions & 1 deletion tests/test_scan_prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ def test_scan_prompts_blocks_malicious_prompt(tmp_path, monkeypatch):

assert exit_code == 1
assert (tmp_path / "report.json").exists()

client.post.assert_called_once()

args, kwargs = client.post.call_args
assert "ignore all previous instructions" in str(kwargs)


def test_scan_prompts_passes_clean_prompt(tmp_path, monkeypatch):
Expand Down Expand Up @@ -65,4 +70,9 @@ def test_scan_prompts_passes_clean_prompt(tmp_path, monkeypatch):
exit_code = module.main()

assert exit_code == 0
assert (tmp_path / "report.json").exists()
assert (tmp_path / "report.json").exists()

client.post.assert_called_once()

args, kwargs = client.post.call_args
assert "Summarize the policy in three bullets." in str(kwargs)