fix(frontend): replace useState with useRef for auto-save timeout in DocumentEditor#1009
Open
hemish22 wants to merge 2 commits into
Open
fix(frontend): replace useState with useRef for auto-save timeout in DocumentEditor#1009hemish22 wants to merge 2 commits into
hemish22 wants to merge 2 commits into
Conversation
Silent catch block only logged to console, giving no feedback when save failed. Add saveError state and render a red message in the toolbar on failure so users know their changes were not persisted. Fixes SdSarthak#325 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
saveTimeout in useState caused useEffect to re-run on every setSaveTimeout call, creating an infinite debounce loop. useRef holds the timer ID without triggering re-renders. Also removed redundant setIsSaving calls in the timeout callback since handleSave already manages isSaving state. Fixes SdSarthak#325 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #325
saveTimeoutwasuseState→ everysetSaveTimeoutcall triggereduseEffectre-run → infinite debounce loop (new timeout created before old one fires)useRef— stores timer ID without causing re-renderssetIsSaving(true/false)in timeout callback (handleSavealready manages this)Changes
frontend/src/components/DocumentEditor.tsxuseState→useReffor timeout; remove redundant state calls;saveTimeoutremoved from effect depsBefore / After
Before — effect deps included
saveTimeout:After — ref never triggers re-render:
Test Plan
AI Disclosure
Fix implemented with Claude Code (claude-sonnet-4-6).