Skip to content

Conversation

@EHadoux
Copy link
Contributor

@EHadoux EHadoux commented Mar 12, 2025

  • Moved to Poetry for a more contemporary deps/build system
  • Removed any ref to the Federated ID pool -> makes this library incompatible with MI v1

@EHadoux EHadoux self-assigned this Mar 12, 2025
@EHadoux EHadoux requested a review from Copilot March 12, 2025 17:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the project by moving dependency management and builds to Poetry and by removing the federated ID pool functionality. Key changes include:

  • Introduction of a pyproject.toml for Poetry-based dependency management.
  • Updates to CI workflows and tests to align with the Poetry build system and Python 3.11.
  • Removal of code related to federated ID, credentials, and signature generation features.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml New project configuration using Poetry
.github/workflows/*.yml Updated workflows to install dependencies via Poetry and Python 3.11
docs_source/conf.py Updated release handling and copyright for 2025
scribeauth/scribeauth.py Reworked authentication logic, replaced TypedDicts with dataclasses, and removed federated ID features
tests/test_scribeauth.py Updated tests to use pytest and removed federated ID tests
scribeauth/main.py Updated CLI to use new ScribeAuth constructor and dataclass checks
README.md & LICENSE.md Adjusted documentation and license year
scribeauth/init.py Reflected removal of federated functionality
setup.py Removed in favor of Poetry's pyproject.toml
Comments suppressed due to low confidence (2)

scribeauth/scribeauth.py:259

  • Avoid using a bare except clause here; instead, catch specific exceptions to prevent masking unexpected errors.
        except:

tests/test_scribeauth.py:31

  • [nitpick] Consider using a consistent test class structure across all tests; for example, either subclass unittest.TestCase or use plain pytest functions consistently.
class TestScribeAuthGetTokensNoMFA:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants