Expand WinUI FileSystemAdapter test coverage: functional combinations and full guard coverage#31
Draft
Copilot wants to merge 4 commits into
Draft
Expand WinUI FileSystemAdapter test coverage: functional combinations and full guard coverage#31Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
…ions, ReadWrite mode Co-authored-by: Kumara-Krishnan <5687650+Kumara-Krishnan@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Exclude picker classes from coverage due to untestable OS dialogs
Expand WinUI integration tests beyond argument-guard coverage
Mar 1, 2026
…ethod overloads Co-authored-by: Kumara-Krishnan <5687650+Kumara-Krishnan@users.noreply.github.com>
Copilot
AI
changed the title
Expand WinUI integration tests beyond argument-guard coverage
Expand WinUI handler test coverage: missing overloads and second-argument guards
Mar 1, 2026
…handler combinations Co-authored-by: Kumara-Krishnan <5687650+Kumara-Krishnan@users.noreply.github.com>
Copilot
AI
changed the title
Expand WinUI handler test coverage: missing overloads and second-argument guards
Expand WinUI FileSystemAdapter test coverage: functional combinations and full guard coverage
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were limited to a subset of argument-guard checks and shallow existence assertions — no content verification, no collision-option combinations, and many handler overloads were untested entirely.
Argument guard completeness (
FileSystemAdapterTests.cs)Added 18 unit tests covering every previously untested type guard:
CopyAndReplaceAsync,CopyAsync,MoveAndReplaceAsync, and all threeMoveAsyncoverloadsCreateFileAsync(+option),CreateFolderAsync(+option),DeleteAsync(+option),GetFileAsync(all-files),GetFoldersAsync,GetItemAsync,GetItemsAsync,GetParentAsync,RenameAsync(+option),TryGetItemAsyncDestination-guard tests obtain a real
WinUIFileviaGetFileFromPathAsync(the only way to construct theinternaltype) so the first guard passes and the second is the code path under test:Functional integration coverage (
FileSystemAdapterIntegrationTests.cs)Added 32 integration tests across 11 new regions verifying actual behaviour and data correctness:
CopyAsync,MoveAsync,RenameAsync,CreateFileAsync,CreateFolderAsync—FailIfExiststhrowsIOException;GenerateUniqueNameleaves both items on disk;ReplaceExistingoverwrites content / removes old pathPath,Name,FolderRelativeIdexact values;GetItemAsyncreturnsIFilevsIFoldercorrectly;GetSizeAsyncreturns exactly5ULfor a known 5-byte fileGetFileAsync,GetFoldersAsync,GetItemsAsyncreturn empty (not null/error)GetItemAsyncthrowsFileNotFoundExceptionOpenAsync(AllowReadersAndWriters)andStorageDeletionOption.Default— previously untested overloadsWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
az667904.vo.msecnd.net/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/10.0.102/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false(dns block)vortex.data.microsoft.com/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/10.0.102/MSBuild.dll /noautoresponse /nologo /nodemode:1 /nodeReuse:true /low:false(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.