Skip to content

Fix workflow stalling on self-hosted runners by converting string literals to arrays #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kumara-Krishnan merged 5 commits into from
Jan 30, 2026
Merged

Fix workflow stalling on self-hosted runners by converting string literals to arrays #71

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9e8417
Initial plan
Copilot Jan 29, 2026
9f51731
Fix runs-on expressions to use fromJSON for proper array handling
Copilot Jan 29, 2026
4b58028
Remove redundant pull_request check from package job runs-on
Copilot Jan 29, 2026
be58127
Fix checkout ref for pull requests to use github.head_ref
Copilot Jan 30, 2026
d3d3223
Simplify ref in deploy-to-cloudflare job (never runs on PRs)
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/msix-build-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ permissions:
jobs:
bump-version:
name: Bump Version
runs-on: ${{ (github.event_name == 'pull_request' || (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted')) && '[self-hosted, windows]' || 'windows-latest' }}
runs-on: ${{ (github.event_name == 'pull_request' || (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted')) && fromJSON('["self-hosted", "windows"]') || 'windows-latest' }}
outputs:
version: ${{ steps.version.outputs.version }}

Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:

build:
name: Build Solution
runs-on: ${{ (github.event_name == 'pull_request' || (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted')) && '[self-hosted, windows]' || 'windows-latest' }}
runs-on: ${{ (github.event_name == 'pull_request' || (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted')) && fromJSON('["self-hosted", "windows"]') || 'windows-latest' }}
needs: bump-version

steps:
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:

package:
name: Create Package
runs-on: ${{ (github.event_name == 'pull_request' || (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted')) && '[self-hosted, windows]' || 'windows-latest' }}
runs-on: ${{ (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted') && fromJSON('["self-hosted", "windows"]') || 'windows-latest' }}
needs: [bump-version, build]
if: github.event_name != 'pull_request'

Expand Down Expand Up @@ -233,7 +233,7 @@ jobs:

release:
name: Create Release
runs-on: ${{ (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted') && '[self-hosted, windows]' || 'windows-latest' }}
runs-on: ${{ (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted') && fromJSON('["self-hosted", "windows"]') || 'windows-latest' }}
needs: [bump-version, package]
if: github.event_name != 'pull_request'
outputs:
Expand All @@ -259,7 +259,7 @@ jobs:

deploy-to-cloudflare:
name: Deploy to Cloudflare Pages
runs-on: ${{ (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted') && '[self-hosted, linux]' || 'ubuntu-latest' }}
runs-on: ${{ (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted') && fromJSON('["self-hosted", "linux"]') || 'ubuntu-latest' }}
needs: [bump-version, package, release]
if: github.event_name != 'pull_request'

Expand Down Expand Up @@ -433,7 +433,7 @@ jobs:

deploy-docs:
name: Deploy to GitHub Pages
runs-on: ${{ (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted') && '[self-hosted, linux]' || 'ubuntu-latest' }}
runs-on: ${{ (github.event_name == 'workflow_dispatch' && inputs.runner_type == 'self-hosted') && fromJSON('["self-hosted", "linux"]') || 'ubuntu-latest' }}
needs: build
if: github.event_name != 'pull_request'
environment:
Expand Down
Loading