fix(rate-limit): prevent X-Forwarded-For spoof bypass#299
Merged
Scottcjn merged 1 commit intoScottcjn:mainfrom Feb 20, 2026
Merged
fix(rate-limit): prevent X-Forwarded-For spoof bypass#299Scottcjn merged 1 commit intoScottcjn:mainfrom
Scottcjn merged 1 commit intoScottcjn:mainfrom
Conversation
Contributor
Author
|
Review Tier Label Gate is failing only due to missing BCOS tier label on this non-doc PR.\n\nThis is a focused API security hardening fix (XFF spoof -> rate-limit bypass), so BCOS-L1 seems appropriate.\n\nCould a maintainer add BCOS-L1 (or �cos:l1) and re-run checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- harden client_ip_from_request() against X-Forwarded-For spoofing\n- when request comes from trusted proxy, resolve client IP from right-to-left chain and select first non-trusted hop\n- ignore invalid XFF hops and fall back safely to
emote_addr\n- add regression tests for spoofed left-most XFF and untrusted-remote behavior\n\n## Why\nCurrent behavior trusts the first XFF hop when request arrives via trusted proxy.\nWith common proxy append behavior, attacker-controlled left-most values can bypass IP-based anti-abuse controls (including attestation IP rate limiting).\n\n## Test\n- python -m py_compile node/rustchain_v2_integrated_v2.2.1_rip200.py\n- python -m pytest tests/test_api.py -q\n\n## Related\n- rustchain-bounties#57