fix(wallet): reject sub-micro transfer amounts

Co-authored-by: liu971227-sys <[email protected]>

Author: liu971227-sys

node/payout_preflight.py

@@ -44,11 +44,23 @@ def validate_wallet_transfer_admin(payload: Any) -> PreflightResult:
         return PreflightResult(ok=False, error=aerr, details={})
     if amount_rtc is None or amount_rtc <= 0:
         return PreflightResult(ok=False, error="amount_must_be_positive", details={})
+    amount_i64 = int(amount_rtc * 1_000_000)
+    if amount_i64 <= 0:
+        return PreflightResult(
+            ok=False,
+            error="amount_too_small_after_quantization",
+            details={"amount_rtc": amount_rtc, "min_rtc": 0.000001},
+        )
 
     return PreflightResult(
         ok=True,
         error="",
-        details={"from_miner": str(from_miner), "to_miner": str(to_miner), "amount_rtc": amount_rtc},
+        details={
+            "from_miner": str(from_miner),
+            "to_miner": str(to_miner),
+            "amount_rtc": amount_rtc,
+            "amount_i64": amount_i64,
+        },
     )
 
 
@@ -70,6 +82,13 @@ def validate_wallet_transfer_signed(payload: Any) -> PreflightResult:
         return PreflightResult(ok=False, error=aerr, details={})
     if amount_rtc is None or amount_rtc <= 0:
         return PreflightResult(ok=False, error="amount_must_be_positive", details={})
+    amount_i64 = int(amount_rtc * 1_000_000)
+    if amount_i64 <= 0:
+        return PreflightResult(
+            ok=False,
+            error="amount_too_small_after_quantization",
+            details={"amount_rtc": amount_rtc, "min_rtc": 0.000001},
+        )
 
     if not (from_address.startswith("RTC") and len(from_address) == 43):
         return PreflightResult(ok=False, error="invalid_from_address_format", details={})
@@ -88,6 +107,12 @@ def validate_wallet_transfer_signed(payload: Any) -> PreflightResult:
     return PreflightResult(
         ok=True,
         error="",
-        details={"from_address": from_address, "to_address": to_address, "amount_rtc": amount_rtc, "nonce": nonce_int},
+        details={
+            "from_address": from_address,
+            "to_address": to_address,
+            "amount_rtc": amount_rtc,
+            "amount_i64": amount_i64,
+            "nonce": nonce_int,
+        },
     )
 

node/tests/test_payout_preflight.py

@@ -21,6 +21,20 @@ def test_admin_ok(self):
         r = validate_wallet_transfer_admin({"from_miner": "a", "to_miner": "b", "amount_rtc": 1})
         self.assertTrue(r.ok)
 
+    def test_admin_rejects_sub_micro_amount(self):
+        r = validate_wallet_transfer_admin(
+            {"from_miner": "a", "to_miner": "b", "amount_rtc": 0.0000001}
+        )
+        self.assertFalse(r.ok)
+        self.assertEqual(r.error, "amount_too_small_after_quantization")
+
+    def test_admin_accepts_min_quantized_amount(self):
+        r = validate_wallet_transfer_admin(
+            {"from_miner": "a", "to_miner": "b", "amount_rtc": 0.000001}
+        )
+        self.assertTrue(r.ok)
+        self.assertEqual(r.details.get("amount_i64"), 1)
+
     def test_signed_rejects_missing(self):
         r = validate_wallet_transfer_signed({"from_address": "RTC" + "a" * 40})
         self.assertFalse(r.ok)
@@ -51,6 +65,32 @@ def test_signed_ok_shape(self):
         r = validate_wallet_transfer_signed(payload)
         self.assertTrue(r.ok)
 
+    def test_signed_rejects_sub_micro_amount(self):
+        payload = {
+            "from_address": "RTC" + "a" * 40,
+            "to_address": "RTC" + "b" * 40,
+            "amount_rtc": 0.0000001,
+            "nonce": "123",
+            "signature": "00",
+            "public_key": "00",
+        }
+        r = validate_wallet_transfer_signed(payload)
+        self.assertFalse(r.ok)
+        self.assertEqual(r.error, "amount_too_small_after_quantization")
+
+    def test_signed_accepts_min_quantized_amount(self):
+        payload = {
+            "from_address": "RTC" + "a" * 40,
+            "to_address": "RTC" + "b" * 40,
+            "amount_rtc": 0.000001,
+            "nonce": "123",
+            "signature": "00",
+            "public_key": "00",
+        }
+        r = validate_wallet_transfer_signed(payload)
+        self.assertTrue(r.ok)
+        self.assertEqual(r.details.get("amount_i64"), 1)
+
 
 if __name__ == "__main__":
     unittest.main()

payout_preflight.py

@@ -48,11 +48,23 @@ def validate_wallet_transfer_admin(payload: Any) -> PreflightResult:
         return PreflightResult(ok=False, error=aerr, details={})
     if amount_rtc is None or amount_rtc <= 0:
         return PreflightResult(ok=False, error="amount_must_be_positive", details={})
+    amount_i64 = int(amount_rtc * 1_000_000)
+    if amount_i64 <= 0:
+        return PreflightResult(
+            ok=False,
+            error="amount_too_small_after_quantization",
+            details={"amount_rtc": amount_rtc, "min_rtc": 0.000001},
+        )
 
     return PreflightResult(
         ok=True,
         error="",
-        details={"from_miner": str(from_miner), "to_miner": str(to_miner), "amount_rtc": amount_rtc},
+        details={
+            "from_miner": str(from_miner),
+            "to_miner": str(to_miner),
+            "amount_rtc": amount_rtc,
+            "amount_i64": amount_i64,
+        },
     )
 
 
@@ -74,6 +86,13 @@ def validate_wallet_transfer_signed(payload: Any) -> PreflightResult:
         return PreflightResult(ok=False, error=aerr, details={})
     if amount_rtc is None or amount_rtc <= 0:
         return PreflightResult(ok=False, error="amount_must_be_positive", details={})
+    amount_i64 = int(amount_rtc * 1_000_000)
+    if amount_i64 <= 0:
+        return PreflightResult(
+            ok=False,
+            error="amount_too_small_after_quantization",
+            details={"amount_rtc": amount_rtc, "min_rtc": 0.000001},
+        )
 
     if not (from_address.startswith("RTC") and len(from_address) == 43):
         return PreflightResult(ok=False, error="invalid_from_address_format", details={})
@@ -92,6 +111,12 @@ def validate_wallet_transfer_signed(payload: Any) -> PreflightResult:
     return PreflightResult(
         ok=True,
         error="",
-        details={"from_address": from_address, "to_address": to_address, "amount_rtc": amount_rtc, "nonce": nonce_int},
+        details={
+            "from_address": from_address,
+            "to_address": to_address,
+            "amount_rtc": amount_rtc,
+            "amount_i64": amount_i64,
+            "nonce": nonce_int,
+        },
     )