Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mise add warning about migration #6484

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ev-dev
Copy link
Contributor

@ev-dev ev-dev commented Jan 24, 2025

  • Adds warning message about manual config migration.
  • Update to version 2025.1.13

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

mise

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@ev-dev ev-dev marked this pull request as ready for review January 24, 2025 05:31
@ev-dev
Copy link
Contributor Author

ev-dev commented Jan 24, 2025

I'll look into scripting a migration of previous mise installs, but it may not be necessary. Is a warning message alone an acceptable UX?

@ev-dev ev-dev changed the title mise add config migration mise add warning about migration Jan 24, 2025
@stevehipwell
Copy link
Contributor

@ev-dev it'd be best if scoop didn't modify existing mise configuration, the install script could check for non-scoop values in the env. See #6477.

@ev-dev
Copy link
Contributor Author

ev-dev commented Jan 28, 2025

Indeed, I agree @stevehipwell this PR simply adds the warning message:

This manifest does not currently migrate any previous mise installations!

Suggested:

  • Backup existing config.toml before fully uninstalling mise as documented.
  • Install with scoop then manually add the backed up options to the new config.toml that scoop now manages in persist

My thought was that the best way to ovoid an install conflict with previous installs, would be to have a clean install with scoop. I figured this message would at least be better than not addressing or mentioning previous installs no?

@stevehipwell
Copy link
Contributor

The whole mise Scoop installation breaks existing configuration, the warning message doesn't really deal with that as it suggest that the intended behaviour is to replace the existing env variables and paths. The best solution would be to use an install script to detect if mise has been configured already to point outside the Scoop dir and if so not change anything related to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants