Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 20, 2025

Changes:

  • Changed checkver and downloads to use GitHub.
  • Updated to 2.1.3.
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Updates
    • Version bumped to 2.1.3
    • Migrated package sources to GitHub releases for enhanced reliability and accessibility
    • Improved architecture-specific configurations for 32-bit and 64-bit support

Updated version and download URLs for 32bit and 64bit executables.
@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 20, 2025

Related: #16379.

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

Walkthrough

Scoop manifest for the executor package was updated with version bump from 1.0.11 to 2.1.3, migration of binary sources from legacy domain to GitHub releases, and configuration updates for version checking and auto-update functionality.

Changes

Cohort / File(s) Summary
Manifest versioning and source migration
bucket/executor.json
Version incremented to 2.1.3; architecture-specific downloads migrated from legacy sources to GitHub releases with updated URLs and checksums; checkver and autoupdate blocks rewritten to use GitHub release endpoints with version parameterization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Configuration file update with straightforward manifest changes—primarily verification of correct URLs, hash values, and version parameters.

Possibly related PRs

Poem

🐰 A package updated, now versions align,
From legacy paths to GitHub's design,
The executor hops to release day,
With checksums verified and URLs at play! ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description provides a brief summary of changes (changed checkver and downloads to use GitHub, updated to version 2.1.3) and both required checklist items are properly checked off. However, the description is missing a critical required element from the template: an issue reference in the format of Closes #XXXX or Relates to #XXXX. While the PR objectives indicate that issue #16379 was mentioned in comments, the template explicitly requires this reference to be included in the PR description itself. According to the template, opening a relevant issue for discussion with maintainers is mandatory before creating a PR, and this should be documented in the description.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "executor: Update to version 2.1.3, fix checkver & autoupdate" is clear, concise, and directly relates to the main changes in the pull request. It follows the conventional format with the manifest name, version update, and the key fixes (checkver and autoupdate modifications). The title accurately summarizes the primary changes reflected in the raw_summary without being vague or overly broad.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

executor

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title [email protected]: Updated and fixed checkver executor: Update to version 2.1.2, fix checkver & autoupdate Oct 23, 2025
@z-Fng z-Fng changed the title executor: Update to version 2.1.2, fix checkver & autoupdate executor: Update to version 2.1.3, fix checkver & autoupdate Oct 23, 2025
@z-Fng
Copy link
Member

z-Fng commented Oct 23, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

executor

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@z-Fng z-Fng merged commit f4d286b into ScoopInstaller:master Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants