Skip to content

Conversation

o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 20, 2025

Changes:

  • Updated to 3.9.7
  • Sorted architectures alphabetically
  • Fixed checkver.
  • Fixed bin: CLI tool is now named "tageditor-cli".
  • Removed pre-install: No longer needed.
  • Removed 32bit, added ARM64
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for ARM64 architecture.
  • Chores

    • Updated version to 3.9.7.
    • Dropped support for 32-bit systems.
    • Updated installation resources and binary executable name.

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 20, 2025

Related: #16379.

@coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2025

Walkthrough

Updated tageditor package manifest to version 3.9.7, removing 32-bit architecture support, adding ARM64 support with new download URLs and checksums, changing binary target to tageditor-cli.exe, and removing pre-install instructions.

Changes

Cohort / File(s) Summary
Package manifest update
bucket/tageditor.json
Version bumped to 3.9.7; 32-bit architecture removed; 64-bit and ARM64 URLs and hashes updated; binary target changed from tageditor.exe to tageditor-cli.exe; pre-install instruction removed; autoupdate section restructured for new architectures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 A package hops forward with version three-point-nine-seven in sight,
Dropping thirty-two-bit chains, ARM64 shines so bright!
The CLI binary takes center stage,
New URLs and hashes turn the page! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[email protected]: Updated, fixed checkver" follows the conventional format specified in the repository (<manifest-name[@version]>: <general summary>), clearly indicating the package name, version update to 3.9.7, and the key changes (update and checkver fix). The title accurately summarizes the main objectives of the changeset—updating the package version and fixing the version check configuration—without attempting to cover all details, which aligns with the principle that titles don't need to be exhaustive. The title is specific enough that a teammate reviewing the history would quickly understand the primary change.
Description Check ✅ Passed The pull request description includes all essential components from the template: a clear, detailed list of changes, and both required checklist items explicitly checked. The description provides comprehensive information about what was changed (version bump, architecture reorganization, binary rename, removal of pre_install), making it easy to understand the intent. While the description omits the explicit issue reference line (Closes/Relates to #XXXX format), this is a minor formatting detail; the PR objectives confirm the related issue was referenced in comments, and the two mandatory checklist confirmations are present and checked.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c4a7125 and 249a120.

📒 Files selected for processing (1)
  • bucket/tageditor.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/tageditor.json (3)

16-16: Verify executable name in shortcuts matches updated bin target.

The bin field has been changed to tageditor-cli.exe (line 16), but the shortcuts section still references tageditor.exe (line 19). If tageditor.exe no longer exists in version 3.9.7, the shortcut will fail.

Please confirm whether:

  1. Both executables (tageditor-cli.exe and tageditor.exe) exist in the 3.9.7 release, or
  2. The shortcut should be updated to reference tageditor-cli.exe instead.

If the shortcut should reference tageditor-cli.exe, apply this diff:

     "shortcuts": [
         [
-            "tageditor.exe",
+            "tageditor-cli.exe",
             "Tag Editor"
         ]
     ],

Also applies to: 19-19


2-2: Version bump and architecture updates look consistent.

The version has been correctly bumped to 3.9.7 across all URL references. The removal of 32-bit support and addition of ARM64 support is properly reflected in both the architecture and autoupdate sections with correct download URLs and hashes.

Also applies to: 8-9, 11-14, 27-27, 29-31


23-23: checkver configuration verified — GitHub API resolves versions correctly

The checkver: "github" configuration is correct. The GitHub API successfully retrieves the latest release tag (v3.9.7) from the Martchus/tageditor repository, confirming that version detection works as expected.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

tageditor

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant