[email protected]: Update and fix checkver

[o-l-a-v]

Changes:

• Update to v8.4.9
• Change to x64, as download specifically says amd64
• Fix checkver
• PowerShell cleanup
  • Specify parameter names
  • Use $null = instead of | Out-Null
  • Use -not instead of !

• Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
• I have read the Contributing Guide

Summary by CodeRabbit

• New Features

  • Added native 64-bit architecture support.

• Changes

  • Updated to version 8.4.9.
  • Streamlined installation shortcuts—FAHClient.exe shortcut is now the primary entry point, with FAHControl and FAHViewer shortcuts removed.

[coderabbitai]

Walkthrough

Updates the Folding@Home Scoop manifest from version 7.6.21 to 8.4.9, introducing architecture-specific 64-bit download handling, modernizing PowerShell syntax in pre-install scripts, simplifying version checking with regex patterns, and removing deprecated shortcuts.

Changes

Cohort / File(s)	Summary
Folding@Home Manifest Update bucket/folding-at-home.json	Version bump to 8.4.9; migrated download URL/hash to architecture-specific structure with 64-bit support; updated pre-install PowerShell script with modern syntax (Remove-Item, Set-Content with explicit parameters); removed FAHControl and FAHViewer shortcuts; refactored checkver from scripted PowerShell to regex-based approach; updated autoupdate to architecture-specific 64-bit URL pattern.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

The single-file change spans multiple heterogeneous sections (version metadata, PowerShell scripting, URL/regex patterns, checkver/autoupdate logic) requiring separate reasoning for correctness in each area, particularly around URL pattern validity and PowerShell syntax accuracy.

Possibly related PRs

• ScoopInstaller/Extras#16343: Applies identical manifest-level refactors with architecture-specific 64-bit structures and checkver/autoupdate JSON-to-regex migrations.

Suggested labels

review-needed

Suggested reviewers

• z-Fng

Poem

🐰 A rabbit hops with joy today,
FAH package now the modern way!
Sixty-four bits, the future's bright,
PowerShell spruced up—syntax tight!
Version climbs, from six to eight,
Scoop's folding dreams feel truly great! 🧬

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[email protected]: Update and fix checkver" follows the repository's conventional format and clearly summarizes the primary changes in the changeset: a version bump to 8.4.9 and a checkver fix. The title is specific, concise, and avoids vague language, making it clear to reviewers scanning the history what the main objectives of the PR are. The title accurately reflects the substantive changes documented in the raw summary.
Description Check	✅ Passed	The PR description provides a clear and organized list of changes including the version update, architecture change to x64, checkver fix, and PowerShell cleanup details. Both mandatory checklist items are properly completed and confirmed: the conventional PR title format is marked, and the contributor confirms reading the Contributing Guide. While the description lacks an explicit issue reference (Closes #XXXX), the core required elements are present, and the changes are substantively documented with specific technical details.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bb839e and 2b9b56e.

📒 Files selected for processing (1)

• bucket/folding-at-home.json (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-10-16T15:59:21.258Z

Learnt from: o-l-a-v
PR: ScoopInstaller/Extras#16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.

Applied to files:

• bucket/folding-at-home.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: WindowsPowerShell

🔇 Additional comments (4)

bucket/folding-at-home.json (4)

43-48: Verify autoupdate URL will form valid URI after variable substitution.

The autoupdate URL contains the $version variable that gets substituted during updates. Ensure that after substitution (e.g., $version → 8.4.9), the resulting URL is a valid, complete URI: https://download.foldingathome.org/releases/public/fah-client/windows-10-64bit/release/fah-client_8.4.9_AMD64.exe#/dl.7z.

Based on learnings, autoupdate.architecture.<arch>.url fields must conform to URI format. Verify this pattern produces valid URIs.

---

16-20: PowerShell syntax changes look good.

The pre-install script updates use explicit parameter names (-Path, -Force, -Recurse, -Value, -Encoding) and $null = assignment instead of pipe-to-Out-Null, which is more idiomatic. The conditional logic with -not is also correct. Verify the logic handles edge cases appropriately (e.g., when files don't exist).

---

38-41: Regex pattern verified successfully.

The regex _([\\d.]+)_ correctly extracts version strings from the FAH release directory. Testing against actual filenames (fah-client_8.3.17_AMD64.exe, fah-client_8.3.18_AMD64.exe, fah-client_8.4.9_AMD64.exe) confirms pattern matching works as expected, with reverse: true properly identifying version 8.4.9 as the latest release.

---

9-14: No action needed — 64-bit-only architecture is correct and intentional.

Folding@home v8.4.9 was released only as 64-bit Windows builds; there is no official 32-bit v8.4.9 installer. The manifest accurately reflects the available upstream releases. The architecture specification correctly specifies 64-bit only because alternative binaries do not exist for this version.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

All changes look good.

Wait for review from human collaborators.

folding-at-home

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[o-l-a-v]

Related: #16379.