Skip to content

Conversation

@o-l-a-v
Copy link
Contributor

@o-l-a-v o-l-a-v commented Oct 19, 2025

Changed:

  • Fixed checkver
  • Updated homepage

Because:

  • Checkver stopped working
  • Homepage changed slightly
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Updates
    • Updated package metadata to reflect new download path and improved version detection for Color Sustainer (ICC Profile Enforcer).

@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2025

Walkthrough

Updated a manifest file with revised download URL, modified version-detection regex pattern to match new release banner format with "(ICC Profile Enforcer)" text, and removed the reverse field from version checking configuration.

Changes

Cohort / File(s) Summary
Manifest Configuration Update
bucket/color-sustainer.json
Updated homepage URL path; modified checkver regex to match new release banner pattern with "(ICC Profile Enforcer)" text; removed checkver.reverse property

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A URL hops to a shinier place,
The regex now catches new patterns with grace,
ICC Profile Enforcer joins the version dance,
Reverse takes a bow, exits the stance,
One simple manifest, updated with care! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[email protected]: Fix checkver and homepage" is directly related to the main changes in the changeset. It follows the conventional format specified in the template (<manifest-name[@version]|chore>: <general summary of the pull request>), is concise and clear, and accurately reflects the two primary modifications: fixing the checkver regex pattern and updating the homepage URL. A teammate reviewing the history would quickly understand that this PR addresses checkver and homepage issues for the color-sustainer package.
Description Check ✅ Passed The PR description meets the template requirements by including a "Changed" section explaining what was modified, a "Because" section providing reasoning for the changes, and both required checkboxes properly marked as completed. The description confirms the author used the conventional PR title format and has read the Contributing Guide. While the description could have included an explicit "Relates to #16379" reference in the body itself (instead of only in comments), the overall structure and content are sufficient and informative, with the related issue being documented in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37348dc and 77eaa15.

📒 Files selected for processing (1)
  • bucket/color-sustainer.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/color-sustainer.json (2)

4-4: Verify that the updated homepage URL is valid and points to the correct page.

The homepage URL was updated from the /files-details/ path to /download/ path. Ensure this URL is accessible and displays the correct software information.

Can you verify that https://www.guru3d.com/download/color-sustainer-download is the correct and current homepage URL for Color Sustainer?


15-17: Verify that the updated checkver regex correctly matches the website's version detection.

The checkver regex was updated to match the new release banner format with "(ICC Profile Enforcer)" text and v prefix. The version capture group was also modified from ([\\d.]+) to ([\\d.]+[\\d]) to ensure the pattern ends with a digit.

Ensure that:

  1. The regex pattern matches the actual HTML structure on the website
  2. The version extraction produces the correct version number (e.g., "1.05" for the current manifest)
  3. The removal of the reverse field is correct (i.e., the first match should be the desired version, not the last)

Can you confirm that the checkver regex successfully detects version "1.05" (or newer versions) from the guru3d website? You may also want to test the regex pattern against a sample of the website's HTML to ensure it correctly extracts the version number.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

color-sustainer

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@o-l-a-v
Copy link
Contributor Author

o-l-a-v commented Oct 19, 2025

Related: #16379.

Removed the script line from the checkver section.
@z-Fng
Copy link
Member

z-Fng commented Oct 22, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

color-sustainer

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng merged commit 78409f3 into ScoopInstaller:master Oct 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants