Skip to content

Add information about streamlit limits against #107#129

Merged
lfoppiano merged 1 commit into
mainfrom
bugfix/defensive-against-107
Apr 24, 2026
Merged

Add information about streamlit limits against #107#129
lfoppiano merged 1 commit into
mainfrom
bugfix/defensive-against-107

Conversation

@lfoppiano

Copy link
Copy Markdown
Collaborator

This PR informs uses about the latest streamlit version to be used to avoid #107. The version is no enforced because #107 only occur on specific conditions.

@lfoppiano lfoppiano requested a review from Sanakhamassi April 23, 2026 22:14

@Sanakhamassi Sanakhamassi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and runtime UserWarning appears correctly when importing streamlit_pdf_viewer with Streamlit >= 1.41

  • Warning message is clear and includes:
    • Problem description
    • Link to issue #107
    • Recommended streamlit version (pin streamlit<1.41)
      -Warning does NOT appear with Streamlit 1.41.0 (< 1.41)version so check logic works correctly
  • README updated with "Streamlit compatibility" section explaining the regression

@lfoppiano lfoppiano merged commit 5763803 into main Apr 24, 2026
9 checks passed
@lfoppiano lfoppiano deleted the bugfix/defensive-against-107 branch April 24, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants