Generalise support for netcdf load+save of "special" attributes #6566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6566 +/- ##
==========================================
- Coverage 89.90% 89.66% -0.24%
==========================================
Files 90 91 +1
Lines 24153 24310 +157
Branches 4496 4504 +8
==========================================
+ Hits 21714 21798 +84
- Misses 1679 1751 +72
- Partials 760 761 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pp-mo
added
the
benchmark_this
⏱️ Performance Benchmark Report: 71c7bc4Performance shiftsFull benchmark resultsGenerated by GHA run |
…d/save code, not handlers.
…hout split-attrs.
pp-mo
force-pushed
the
nc_attribute_handlers
branch
from
ad34c83 to
dc0c441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SciTools/iris-grib#596 and SciTools/iris-grib#674
Ties together the handling of STASH, GRIB_PARAM and "ukmo__process_flags" attributes,
which all require special handling on netcdf load+save.
By design, should preserve existing behaviour.
But I have tried to generalise the handling,
( and also rationalise behaviour a wee bit, at least for "ukmo__process_flags" -- though that one is quite obscure ).
TODO:
@staticmethod+ useselfmore(but first, just let's see if it breaks anything I haven't already tried)