-
Notifications
You must be signed in to change notification settings - Fork 297
Move mocked_compute
to conftest.py
#6564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6564 +/- ##
==========================================
+ Coverage 89.91% 89.93% +0.02%
==========================================
Files 90 90
Lines 24153 24166 +13
Branches 4496 4502 +6
==========================================
+ Hits 21716 21733 +17
+ Misses 1678 1672 -6
- Partials 759 761 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: DarkVoyager11 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one more thing to do: making sure that the link works correctly in documentation.
Co-authored-by: DarkVoyager11 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple nitpicks with the whatsnew.
docs/src/whatsnew/latest.rst
Outdated
@@ -147,7 +147,10 @@ This document explains the changes made to Iris for this release | |||
#. `@bjlittle`_ added support for `Trusted Publishing`_ of source distributions | |||
and binary wheels to PyPI and Test PyPI. (:pull:`6543`) | |||
|
|||
|
|||
#. `@ESadek-MO`_ moved `@rcomer`_ s `mocked_compute` testing fixture into the `conftest.py` for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a nitpick but I believe this should be `@rcomer`_'s .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There does need to be a space here I THINK, otherwise formatting goes beserk. I'll add the apostrophe in though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we've been able to get away with just an apostrophe before, might just be having a letter after an underscore which it doesn't like.
iris/docs/src/whatsnew/3.2.rst
Line 317 in 13e3d9f
#. `@wjbenfold`_ contributed `@alastair-gemmell`_'s :ref:`step-by-step guide to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Interesting, I'd never noticed that. I'll push that up.
🚀 Pull Request
Description
Closes #5704.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: