Skip to content

Move mocked_compute to conftest.py #6564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ESadek-MO
Copy link
Contributor

🚀 Pull Request

Description

Closes #5704.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@ESadek-MO ESadek-MO marked this pull request as draft July 16, 2025 11:24
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (13e3d9f) to head (9fcf4ab).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6564      +/-   ##
==========================================
+ Coverage   89.91%   89.93%   +0.02%     
==========================================
  Files          90       90              
  Lines       24153    24166      +13     
  Branches     4496     4502       +6     
==========================================
+ Hits        21716    21733      +17     
+ Misses       1678     1672       -6     
- Partials      759      761       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DarkVoyager11 DarkVoyager11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one more thing to do: making sure that the link works correctly in documentation.

@ESadek-MO ESadek-MO marked this pull request as ready for review July 16, 2025 13:59
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple nitpicks with the whatsnew.

@@ -147,7 +147,10 @@ This document explains the changes made to Iris for this release
#. `@bjlittle`_ added support for `Trusted Publishing`_ of source distributions
and binary wheels to PyPI and Test PyPI. (:pull:`6543`)


#. `@ESadek-MO`_ moved `@rcomer`_ s `mocked_compute` testing fixture into the `conftest.py` for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a nitpick but I believe this should be `@rcomer`_'s .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does need to be a space here I THINK, otherwise formatting goes beserk. I'll add the apostrophe in though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we've been able to get away with just an apostrophe before, might just be having a letter after an underscore which it doesn't like.

#. `@wjbenfold`_ contributed `@alastair-gemmell`_'s :ref:`step-by-step guide to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Interesting, I'd never noticed that. I'll push that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

TST: dask compute pytest fixture
3 participants