Move template share prompt into review body - no more issues #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
commented
Jan 27, 2026
| if changed_parent in ( | ||
| git_root, | ||
| git_root / "benchmarks", | ||
| git_root / "docs" / "src", |
Contributor
Author
There was a problem hiding this comment.
Going back to this given there will no longer be annoying issues raised every time.
(originally removed in #218)
trexfeathers
commented
Jan 27, 2026
Comment on lines
283
to
286
| "- Action the suggestion via a pull request editing/adding the " | ||
| f"relevant file in the [templates directory]({templates_url}). [^1]\n" | ||
| f"relevant file in the [SciTools/.github `templates/` directory]({templates_url}). [^1]\n" | ||
| "- Dismiss the suggestion if the changes are not suitable for " | ||
| "templating." |
Contributor
Author
There was a problem hiding this comment.
Should probably have an explicit statement encouraging the creation of an issue, including an assignee, if now is an inappropriate time to action. That was one of the original intents of automatically raising the issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having lived with templating for a few months, it's clear that there are an annoying number of false positive issues being raised. The review - which must be manually dismissed - is attention grabbing enough, and less annoying.
To-do