Add Val{true} option for complex roots in HomotopyContinuationJL #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the feature requested in issue #688 by adding a
ComplexRoots
type parameter toHomotopyContinuationJL
that acceptsVal{true}
orVal{false}
to control whether complex roots are returned.Changes
HomotopyContinuationJL{AllRoots}
toHomotopyContinuationJL{AllRoots, ComplexRoots}
whereComplexRoots
defaults toVal{false}
for backward compatibilityComplexRoots = Val{true}
Usage
Technical Details
Val{Bool}
for compile-time dispatch as requested in the issueTest plan
u² + 1 = 0
correctly finds roots±i
[u₁² + 1, u₂² + 4] = 0
finds all 4 complex rootsFiles Modified
lib/NonlinearSolveHomotopyContinuation/src/NonlinearSolveHomotopyContinuation.jl
lib/NonlinearSolveHomotopyContinuation/src/solve.jl
lib/NonlinearSolveHomotopyContinuation/test/runtests.jl
lib/NonlinearSolveHomotopyContinuation/test/complex_roots_test.jl
(new)Closes #688
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]